[PM-14421] Access Intelligence: Introduce At-risk Passwords Page #13044
+764
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…consider feature flag for tasksEnabled$
|
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13044 +/- ##
==========================================
+ Coverage 35.28% 35.31% +0.02%
==========================================
Files 3124 3128 +4
Lines 92349 92460 +111
Branches 16793 16799 +6
==========================================
+ Hits 32586 32649 +63
- Misses 57306 57352 +46
- Partials 2457 2459 +2 ☔ View full report in Codecov by Sentry. |
gbubemismith
previously approved these changes
Jan 31, 2025
…21/at-risk-passwords-browser
…21/at-risk-passwords-browser
nick-livefront
requested changes
Feb 11, 2025
| ></i> | ||
| <span slot="secondary">{{ cipher.subTitle }}</span> | ||
| <bit-item-action slot="end"> | ||
| <button |
There was a problem hiding this comment.
❌ A button within a button isn't valid HTML (spec). I usually absolutely the action button in these cases to give the "look" that they are nested.
In this scenarios we'd have to watch out for long cipher names.
nick-livefront
approved these changes
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-14421
📔 Objective
Introduce the At-risk Passwords page for Risk Insights.
📸 Screenshots
Opening At-Risk Passwords Page
Screen.Recording.2025-01-23.at.4.18.19.PM.mov
Screen.Recording.2025-01-28.at.4.01.44.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes