Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17619] Add Intial Windows WebAuthn Plugin Authenticator Bindings Crate #13112

Merged
merged 23 commits into from
Feb 3, 2025

Conversation

coltonhurst
Copy link
Member

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17619

📔 Objective

This adds the crate which will interop with the Windows WebAuthn Plugin Authenticator API's. There is much more to add, this is just the initial placement.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@coltonhurst coltonhurst self-assigned this Jan 28, 2025
Copy link
Contributor

github-actions bot commented Jan 28, 2025

Logo
Checkmarx One – Scan Summary & Details84f9f065-76db-4e90-93ba-8ce0ecfb390c

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.51%. Comparing base (d7c46bb) to head (7531297).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13112   +/-   ##
=======================================
  Coverage   35.50%   35.51%           
=======================================
  Files        3008     3008           
  Lines       90918    90918           
  Branches    16911    16911           
=======================================
+ Hits        32279    32286    +7     
+ Misses      56137    56130    -7     
  Partials     2502     2502           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coltonhurst coltonhurst requested a review from a team as a code owner January 29, 2025 16:08
@coltonhurst coltonhurst requested a review from coroiu January 29, 2025 17:12
jprusik
jprusik previously approved these changes Jan 30, 2025
@coltonhurst coltonhurst requested review from coroiu and jprusik January 31, 2025 23:10
coroiu
coroiu previously approved these changes Feb 3, 2025
@coltonhurst coltonhurst merged commit 8b62dad into main Feb 3, 2025
44 of 46 checks passed
@coltonhurst coltonhurst deleted the autofill/pm-17619/initial-win-pa-bindings branch February 3, 2025 14:53
@coltonhurst
Copy link
Member Author

coltonhurst commented Feb 3, 2025

For posterity: The failed Mac Desktop CI is being looked into internally and is not caused by this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants