-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-17619] Add Intial Windows WebAuthn Plugin Authenticator Bindings Crate #13112
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13112 +/- ##
=======================================
Coverage 35.50% 35.51%
=======================================
Files 3008 3008
Lines 90918 90918
Branches 16911 16911
=======================================
+ Hits 32279 32286 +7
+ Misses 56137 56130 -7
Partials 2502 2502 ☔ View full report in Codecov by Sentry. |
apps/desktop/desktop_native/windows-plugin-authenticator/src/lib.rs
Outdated
Show resolved
Hide resolved
apps/desktop/desktop_native/windows-plugin-authenticator/README.md
Outdated
Show resolved
Hide resolved
apps/desktop/desktop_native/windows-plugin-authenticator/build.rs
Outdated
Show resolved
Hide resolved
apps/desktop/desktop_native/windows-plugin-authenticator/src/lib.rs
Outdated
Show resolved
Hide resolved
apps/desktop/desktop_native/windows-plugin-authenticator/Cargo.lock
Outdated
Show resolved
Hide resolved
apps/desktop/desktop_native/windows-plugin-authenticator/Cargo.toml
Outdated
Show resolved
Hide resolved
For posterity: The failed Mac Desktop CI is being looked into internally and is not caused by this PR. |
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17619
📔 Objective
This adds the crate which will interop with the Windows WebAuthn Plugin Authenticator API's. There is much more to add, this is just the initial placement.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes