Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Unix Not Found Error #13127

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

justindbaur
Copy link
Member

@justindbaur justindbaur commented Jan 29, 2025

🎟️ Tracking

📔 Objective

While doing other work I noticed a fair amount of no result logs on unix operating systems. That is because we weren't special handling that error from secure storage operations and instead logging the error. I think this would have lead to a behavioral difference with secure storage too. It would instead be returning undefined vs null. I changed it to specially check the error like we already do for windows and macos and then making the unhandled errors have a bit more info.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@justindbaur justindbaur requested a review from a team as a code owner January 29, 2025 15:33
Copy link
Contributor

github-actions bot commented Jan 29, 2025

Logo
Checkmarx One – Scan Summary & Details1bb61827-20ef-4452-b1cb-668944ce39bc

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 35.36%. Comparing base (ab19704) to head (8cb8696).

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...atform/main/desktop-credential-storage-listener.ts 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13127      +/-   ##
==========================================
- Coverage   35.36%   35.36%   -0.01%     
==========================================
  Files        3010     3010              
  Lines       91162    91166       +4     
  Branches    16996    16997       +1     
==========================================
  Hits        32238    32238              
- Misses      56426    56430       +4     
  Partials     2498     2498              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants