-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PM-15943] - fix extension flicker when filling in a password #13143
Conversation
Great job, no security vulnerabilities found in this Pull Request |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13143 +/- ##
==========================================
+ Coverage 35.37% 35.38% +0.01%
==========================================
Files 3010 3010
Lines 91176 91150 -26
Branches 16996 16982 -14
==========================================
Hits 32251 32251
+ Misses 56419 56397 -22
+ Partials 2506 2502 -4 ☔ View full report in Codecov by Sentry. |
if (!options.skipLastUsed) { | ||
await this.cipherService.updateLastUsedDate(options.cipher.id); | ||
// In order to prevent a UI update send message to background script to update last used date |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I appreciate this note!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks 👍
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-15943
📔 Objective
This PR fixes an issue where, upon autofilling, the extension UI would quickly reload before closing. The cause was the call to
await this.cipherService.updateLastUsedDate(options.cipher.id);
which was causing the service to re-emit values and the consuming components to re-render. Doing the update in the background avoids the UI flicker but still ensures the last used password is still top of the autofill suggestion list.📸 Screenshots
Screen.Recording.2025-01-29.at.1.11.56.PM.mov
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:
) or similar for great changes:memo:
) or ℹ️ (:information_source:
) for notes or general info:question:
) for questions:thinking:
) or 💭 (:thought_balloon:
) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:
) for suggestions / improvements:x:
) or:warning:
) for more significant problems or concerns needing attention:seedling:
) or ♻️ (:recycle:
) for future improvements or indications of technical debt:pick:
) for minor or nitpick changes