Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-13811] Remove conditional code for extension refresh on web #13145

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

djsmith85
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13811

📔 Objective

With the extension refresh released, the conditional code around the ExtensionRefresh-feature-flag within the web-vault should also be removed.

Changes

  • Enable UI refresh on web by default - f0afb7d
    • Removing all conditional code around the ExtensionRefresh-feature-flag on the web-UI
  • Remove no longer needed extensRefresh helpers - 316d1c5

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Removing all conditional code around the `ExtensionRefresh`-feature-flag on the web-UI
@djsmith85 djsmith85 requested a review from a team as a code owner January 29, 2025 21:52
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsb5b4089a-1fff-4485-9645-0d378a19ea22

Great job, no security vulnerabilities found in this Pull Request

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 35.41%. Comparing base (ef38a96) to head (316d1c5).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
.../src/app/vault/individual-vault/vault.component.ts 0.00% 12 Missing ⚠️
...pps/web/src/app/vault/org-vault/vault.component.ts 0.00% 5 Missing ⚠️
...mponents/vault-items/vault-cipher-row.component.ts 0.00% 2 Missing ⚠️
...idual-vault/vault-header/vault-header.component.ts 0.00% 2 Missing ⚠️
...c/app/vault/individual-vault/add-edit.component.ts 0.00% 1 Missing ⚠️
...t/org-vault/vault-header/vault-header.component.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13145      +/-   ##
==========================================
+ Coverage   35.37%   35.41%   +0.03%     
==========================================
  Files        3010     3008       -2     
  Lines       91148    90998     -150     
  Branches    16982    16953      -29     
==========================================
- Hits        32247    32230      -17     
+ Misses      56399    56268     -131     
+ Partials     2502     2500       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@shane-melton shane-melton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants