refactor(active-user-state-refactor): [PM-12040] Remove ActiveUserSta… #13149
+187
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…te from SSO Service - First pass of work to update the state. In the middle of testing.
…e-user-state-from-sso-login
…om SSO Service - Fix for jslib-services.module.ts
|
New Issues (4)Checkmarx found the following issues in this Pull Request
|
…e-user-state-from-sso-login
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13149 +/- ##
==========================================
+ Coverage 35.38% 35.51% +0.13%
==========================================
Files 3010 3007 -3
Lines 91152 90879 -273
Branches 16985 16909 -76
==========================================
+ Hits 32254 32277 +23
+ Misses 56396 56100 -296
Partials 2502 2502 ☔ View full report in Codecov by Sentry. |
…om SSO Service - Fix main.background.ts
Patrick-Pimentel-Bitwarden
force-pushed
the
auth/pm-12040/remove-active-user-state-from-sso-login
branch
from
4ade22d to
0091a20
Compare
…om SSO Service - Added simple tests
…om SSO Service - Tiny touchups.
Patrick-Pimentel-Bitwarden
requested review from
dani-garcia and
JaredSnider-Bitwarden
JaredSnider-Bitwarden
requested changes
Jan 30, 2025
| @@ -74,12 +76,16 @@ export abstract class SsoLoginServiceAbstraction { | |||
| * Gets the value of the active user's organization sso identifier. | |||
| * | |||
| * This should only be used post successful SSO login once the user is initialized. | |||
| * @param userId The user id for the current | |||
There was a problem hiding this comment.
Nit: comment needs to be finished?
There was a problem hiding this comment.
Thank you for adding this test suite! Love to see our test coverage go up!
Comment on lines
+118
to
+124
| if (userId !== undefined) { | ||
| await this.userOrgSsoIdentifierState(userId).update((_) => organizationIdentifier); | ||
| } else { | ||
| this.logService.warning( | ||
| "Tried to set a new user organization sso identifier with an undefined user id.", | ||
| ); | ||
| } |
There was a problem hiding this comment.
Nit: using the early return approach cleans this up just a bit, but isn't 100% necessary just something to think about for the future.
Example:
if (userId === undefined) {
this.logService.warning(
"Tried to set a new user organization sso identifier with an undefined user id.",
);
return;
}
await this.userOrgSsoIdentifierState(userId).update((_) => organizationIdentifier);
There was a problem hiding this comment.
I prefer that approach too, thanks for catching that. I'll get that fixed in a sec.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-12040
📔 Objective
Update the SSO Login Service to use SingleUserState instead of deprecated ActiveUserState.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes