[PM-17780] Running the exposed passwords synchronously #13163
Merged
+26
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
New Issues (3)Checkmarx found the following issues in this Pull Request
Fixed Issues (1)Great job! The following issues were fixed in this Pull Request
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #13163 +/- ##
=======================================
Coverage 35.48% 35.49%
=======================================
Files 3007 3007
Lines 90872 90879 +7
Branches 16904 16905 +1
=======================================
+ Hits 32250 32257 +7
Misses 56120 56120
Partials 2502 2502 ☔ View full report in Codecov by Sentry. |
djsmith85
approved these changes
Jan 31, 2025
Comment on lines
+276
to
+279
| promises.push(promise); | ||
| } | ||
| }); | ||
| await Promise.all(promises); |
There was a problem hiding this comment.
🌱 As we are using this pattern over a couple of services (password-health.service and exposed-password-report), could you please looking into merging this into a single service, than can be called from the different components/services that need it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-17780
📔 Objective
Running the exposed password api call to hibp synchronously to fix some performance issues.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changes