Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(chore) Update desktop version to 2025.2.1 #13370

Merged
merged 1 commit into from
Feb 12, 2025
Merged

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Feb 12, 2025

📔 Objective

In #13334, we adjusted the desktop/src/package.json and desktop/src/package-lock.json to correct the desktop version from 2025.2.1 to 2025.2.0.

However, we left the version as 2025.2.1 in the desktop/package.json and package-lock.json, which are changed in the Version Bump job.

Since these were left at 2025.2.1, subsequent version bumps (e.g. 6aeab07) bumped to 2025.2.2 instead of 2025.2.1 as it should be.

Once this is in main, both this and 6aeab07 will be picked to rc.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.28%. Comparing base (6aeab07) to head (545b31b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13370   +/-   ##
=======================================
  Coverage   35.28%   35.28%           
=======================================
  Files        3124     3124           
  Lines       92349    92349           
  Branches    16793    16793           
=======================================
  Hits        32586    32586           
  Misses      57306    57306           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@trmartin4 trmartin4 marked this pull request as ready for review February 12, 2025 03:10
Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsbe0ccaf2-36d4-41d1-9254-4318eb5f9548

Great job, no security vulnerabilities found in this Pull Request

@addisonbeck addisonbeck merged commit e45ef6b into main Feb 12, 2025
99 checks passed
@addisonbeck addisonbeck deleted the update-desktop-version branch February 12, 2025 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants