Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-17609] Filter out null emissions during decryption #13374

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

BTreston
Copy link
Contributor

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-17609

📔 Objective

This PR fixes an issue where cipherView$ may emit null during encryption. This is an expected behavior, so we will filter out the null emission at the consumer of this observable.

📸 Screenshots

Screen.Recording.2025-02-12.at.9.21.09.AM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner February 12, 2025 14:32
Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.29%. Comparing base (b036d6c) to head (289a491).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13374   +/-   ##
=======================================
  Coverage   35.29%   35.29%           
=======================================
  Files        3124     3124           
  Lines       92483    92484    +1     
  Branches    16818    16818           
=======================================
+ Hits        32638    32639    +1     
  Misses      57388    57388           
  Partials     2457     2457           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Detailsda8894aa-3280-40be-b416-df760031462a

Great job, no security vulnerabilities found in this Pull Request

@BTreston BTreston merged commit 2b099cd into main Feb 12, 2025
49 checks passed
@BTreston BTreston deleted the ac/pm-17609-trash-warning-shows-outside-trash-folder branch February 12, 2025 18:47
jprusik pushed a commit to jprusik/clients that referenced this pull request Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants