Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-18076] - Fixing compiler null dereference warning. #5457

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

jrmccannon
Copy link
Contributor

@jrmccannon jrmccannon commented Mar 3, 2025

🎟️ Tracking

PM-18076

📔 Objective

Found compiler issue wasn't resolved. This should remove the null dereference warning.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@jrmccannon jrmccannon requested a review from a team as a code owner March 3, 2025 16:15
@jrmccannon jrmccannon requested a review from BTreston March 3, 2025 16:15
Copy link

sonarqubecloud bot commented Mar 3, 2025

Copy link
Contributor

github-actions bot commented Mar 3, 2025

Logo
Checkmarx One – Scan Summary & Detailsb4599b09-d507-4f08-b08e-e0a47b79b946

New Issues (3)

Checkmarx found the following issues in this Pull Request

Severity Issue Source File / Package Checkmarx Insight
MEDIUM CSRF /src/Api/Public/Controllers/CollectionsController.cs: 87
detailsMethod Put at line 87 of /src/Api/Public/Controllers/CollectionsController.cs gets a parameter from a user request from model. This parameter value...
Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 143
detailsMethod Post at line 143 of /src/Api/Controllers/CollectionsController.cs gets a parameter from a user request from model. This parameter value flow...
Attack Vector
MEDIUM CSRF /src/Api/Controllers/CollectionsController.cs: 171
detailsMethod Put at line 171 of /src/Api/Controllers/CollectionsController.cs gets a parameter from a user request from model. This parameter value flows...
Attack Vector

Copy link

codecov bot commented Mar 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.45%. Comparing base (0d89409) to head (cc341c7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5457      +/-   ##
==========================================
- Coverage   47.55%   44.45%   -3.10%     
==========================================
  Files        1530     1530              
  Lines       71003    71003              
  Branches     6373     6373              
==========================================
- Hits        33763    31564    -2199     
- Misses      35820    38072    +2252     
+ Partials     1420     1367      -53     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jrmccannon jrmccannon merged commit 356ae10 into main Mar 4, 2025
53 checks passed
@jrmccannon jrmccannon deleted the jmccannon/ac/pm-18076-fix-dereference branch March 4, 2025 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants