Refactoring for SWEST26 handson #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
```
% mix compile
Compiling 16 files (.ex)
warning: variable "key_expr" is unused (if the variable is not meant to be used, prefix it with an underscore)
│
10 │ key_expr = Map.fetch!(args, :key_expr)
│ ~~~~~~~~
│
└─ lib/zenohex_phoenix_demo/zenohex_manager.ex:10:5: ZenohexPhoenixDemo.ZenohexManager.init/1
warning: this clause cannot match because a previous clause at line 19 always matches
│
21 │ get "/", PageController, :home
│ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
│
└─ lib/zenohex_phoenix_demo_web/router.ex:21
warning: Phoenix.LiveView.Helpers.sigil_L/2 is deprecated. Use ~H instead
│
13 │ ~L"""
│ ~
│
└─ lib/zenohex_phoenix_demo_web/live/zenohex_live.ex:13:5: ZenohexPhoenixDemoWeb.ZenohexLive.render/1
warning: clauses with the same name and arity (number of arguments) should be grouped together, "def handle_event/3" was previously defined (lib/zenohex_phoenix_demo_web/live/zenohex_live.ex:27)
│
49 │ def handle_event("send-msg", %{"input_value" => msg}, socket) do
│ ~
│
└─ lib/zenohex_phoenix_demo_web/live/zenohex_live.ex:49:7
warning: unused alias Subscriber
│
3 │ alias Zenohex.Examples.Subscriber
│ ~
│
└─ lib/zenohex_phoenix_demo_web/live/zenohex_live.ex:3:3
warning: you must require Logger before invoking the macro Logger.error/1
│
57 │ Logger.error(inspect(error))
│ ~
│
└─ lib/zenohex_phoenix_demo/zenohex_manager.ex:57:16: ZenohexPhoenixDemo.ZenohexManager.recv_timeout/1
Generated zenohex_phoenix_demo app
```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SWEST26でのハンズオンでの利用を想定してリファクタリングしています．
#1 と #2 の変更も含まれています．
.tool-versionを整備（ハンズオンには不要だが念のため）0.0.0.0に変更してDocker内部で立ち上げてもアクセスできるようにしたhttp://localhost:4000ならMIX_ENV=devでも実行できるのでその手順を記載