chore(bens): add configs for indexing names from puppynet #1187
Conversation
WalkthroughThe pull request introduces configuration updates across multiple files to support the Shibarium testnet integration. In the Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
renatoalencar
force-pushed
the
renatoalencar/shibarium-testnet-config
branch
from
3249fc3 to
62b3211
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (2)
blockscout-ens/bens-server/config/dev.json (2)
30-37: Consider adding rate limiting configuration for the testnet RPC endpoint.While the network configuration is well-structured, consider adding rate limiting parameters for the RPC endpoint to prevent potential abuse in the testnet environment.
109-115: Consider differentiating testnet meta information.The meta information is identical to the mainnet protocol. Consider:
- Adding "(Testnet)" suffix to
short_nameandtitle- Updating the description to indicate this is for the testnet environment
"meta": { - "short_name": "D3 Connect", - "title": "D3 Connect", + "short_name": "D3 Connect (Testnet)", + "title": "D3 Connect (Testnet)", "description": "D3 Connect is a platform for connecting to the Shibarium network.", "icon_url": "https://i.imgur.com/cD6VIXk.png", "docs_url": "https://docs.d3.app/" }
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
blockscout-ens/bens-server/config/dev.json(3 hunks)blockscout-ens/graph-node/config.toml(1 hunks)blockscout-ens/graph-node/deployer/config.json(1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
- blockscout-ens/graph-node/config.toml
- blockscout-ens/graph-node/deployer/config.json
🧰 Additional context used
🪛 Gitleaks (8.21.2)
blockscout-ens/bens-server/config/dev.json
106-106: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
🔇 Additional comments (1)
blockscout-ens/bens-server/config/dev.json (1)
103-103: Verify address resolution technique change.The testnet protocol uses
"address_resolve_technique": "reverse_registry"while the mainnet uses"addr2name". Please confirm if this difference is intentional and document the reasoning.
| @@ -23,9 +23,18 @@ | |||
| "url": "https://shibariumscan.io" | |||
| }, | |||
| "use_protocols": [ | |||
| "d3_connect" | |||
| "d3_connect_shib" | |||
There was a problem hiding this comment.
💡 Codebase verification
Protocol rename is incomplete and inconsistent
The protocol rename from "d3_connect" to "d3_connect_shib" is not consistently applied. Found multiple instances still using the old name:
- In dev.json: Two configurations using
"type": "d3_connect" - In prod.json: Network 109 configuration still uses
"d3_connect"in protocol list and configuration object
🔗 Analysis chain
Verify protocol rename consistency across the codebase.
The protocol rename from "d3_connect" to "d3_connect_shib" should be reflected in all related configurations and code.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Search for any remaining references to the old protocol name
rg "d3_connect\"" --type json
Length of output: 389
Script:
#!/bin/bash
# Get context around d3_connect occurrences
echo "=== dev.json ==="
rg -B 2 -A 2 "d3_connect\"" blockscout-ens/bens-server/config/dev.json
echo -e "\n=== prod.json ==="
rg -B 2 -A 2 "d3_connect\"" blockscout-ens/bens-server/config/prod.json
Length of output: 1252
Currently names can only be indexed from Shibarium mainnet, this adds the necessary configs for d3 connect subgraph to be indexed from testnet as well.
Summary by CodeRabbit