config(bens): index address lookups for apechain testnet #1242
Conversation
WalkthroughThis update adds support for additional D3 Connect networks and protocols. In the bens-server configuration, new network entries for IDs 33111 and 33139 are introduced with corresponding blockscout URLs, protocols ( Possibly related PRs
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🪛 Gitleaks (8.21.2)blockscout-ens/bens-server/config/dev.json142-142: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) 160-160: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) blockscout-ens/bens-server/config/prod.json468-468: Detected a Generic API Key, potentially exposing access to various services and sensitive operations. (generic-api-key) ⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (5)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
blockscout-ens/graph-node/subgraphs/d3-connect-subgraph/networks.json (1)
24-34: New 'ape-testnet' network entry added:
The new entry correctly defines the "ape-testnet" network with its own "Registry" and "Resolver" sections including the specified addresses and startBlock values. This aligns with the PR objectives to support additional networks.
Note: The presence of an empty key ("": "") is consistent with other entries, but please confirm if it’s intended or could be omitted for clarity.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
blockscout-ens/bens-server/config/dev.json(2 hunks)blockscout-ens/graph-node/config.toml(1 hunks)blockscout-ens/graph-node/deployer/config.json(1 hunks)blockscout-ens/graph-node/subgraphs/d3-connect-subgraph/networks.json(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Unit, doc and integration tests
🔇 Additional comments (6)
blockscout-ens/graph-node/config.toml (3)
51-52: Consistent shard configuration added for shibarium-testnet:
Addingshard = "primary"for the shibarium-testnet chain ensures uniformity with the other chain configurations.
53-58: New chain configuration for 'ape-mainnet':
This section introduces theape-mainnetchain with the correct provider URL (https://rpc.apechain.com) andshardsetting. The configuration is in line with the project’s expansion to support additional networks.
59-63: New chain configuration for 'ape-testnet':
The addition of theape-testnetchain with provider URLhttps://curtis.rpc.caldera.xyz/httpandshard = "primary"is correctly implemented. Ensure that the endpoint connectivity is validated during integration testing.blockscout-ens/graph-node/deployer/config.json (1)
73-77: New protocol configuration for 'd3-connect-ape-testnet':
This new protocol entry appropriately links the "ape-testnet" network to its subgraph by specifying the subgraph path, subgraph name, and the corresponding network. It correctly extends the deployment configuration without altering existing protocols.blockscout-ens/bens-server/config/dev.json (2)
39-47: New network configuration for network ID '33111' (ape-testnet):
This configuration adds support for the "ape-testnet" network by using the correct blockscout URL (https://curtis.explorer.caldera.xyz/) and RPC endpoint (https://curtis.rpc.caldera.xyz/http). Associating it with thed3-connect-ape-testnetprotocol meets the intended design.
48-56: New network configuration for network ID '33139' (ape-mainnet):
The configuration for network ID33139properly specifies the blockscout URL (https://apescan.io/) and RPC URL (https://rpc.apechain.com/) and assigns thed3-connect-ape-mainnetprotocol. This addition is consistent with the overall configuration strategy.
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
blockscout-ens/bens-server/config/prod.json(2 hunks)
🧰 Additional context used
🪛 Gitleaks (8.21.2)
blockscout-ens/bens-server/config/prod.json
468-468: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Unit, doc and integration tests
🔇 Additional comments (2)
blockscout-ens/bens-server/config/prod.json (2)
100-108: LGTM!The network configuration for Apechain testnet (ID: 33111) follows the established pattern and includes all required fields.
468-469: Verify contract addresses.Please verify that these contract addresses are correct for the Apechain testnet:
- Native token contract:
0xA6A33ddE98BAb3ee5262e7e1a14ee5B1F06D0D40- Resolver contract:
0x2ad234136165B59f98cf03f696cB84eaf48E30cF✅ Verification successful
🏁 Script executed:
#!/bin/bash # Description: Verify contract addresses exist on the Apechain testnet # Check if the contracts exist and are verified curl -s -X POST -H "Content-Type: application/json" \ -d '{"jsonrpc":"2.0","method":"eth_getCode","params":["0xA6A33ddE98BAb3ee5262e7e1a14ee5B1F06D0D40", "latest"],"id":1}' \ https://curtis.rpc.caldera.xyz/http curl -s -X POST -H "Content-Type: application/json" \ -d '{"jsonrpc":"2.0","method":"eth_getCode","params":["0x2ad234136165B59f98cf03f696cB84eaf48E30cF", "latest"],"id":1}' \ https://curtis.rpc.caldera.xyz/httpLength of output: 3327
Contract Addresses Verified for Apechain Testnet
Both contract addresses return valid, non-empty contract bytecode on the Apechain testnet. The output from the RPC calls confirms that there is deployed contract code at both addresses:
- Native token contract (
0xA6A33ddE98BAb3ee5262e7e1a14ee5B1F06D0D40)- Resolver contract (
0x2ad234136165B59f98cf03f696cB84eaf48E30cF)Thus, these addresses are correct as per the test output.
🧰 Tools
🪛 Gitleaks (8.21.2)
468-468: Detected a Generic API Key, potentially exposing access to various services and sensitive operations.
(generic-api-key)
| "meta": { | ||
| "short_name": "D3 Connect", | ||
| "title": "D3 Connect", | ||
| "description": "D3 Connect is a platform for connecting to the Shibarium network.", |
There was a problem hiding this comment.
🛠️ Refactor suggestion
Update the protocol description.
The description incorrectly mentions "Shibarium network" for the Apechain testnet protocol.
- "description": "D3 Connect is a platform for connecting to the Shibarium network.",
+ "description": "D3 Connect is a platform for connecting to the Apechain network.",📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "description": "D3 Connect is a platform for connecting to the Shibarium network.", | |
| "description": "D3 Connect is a platform for connecting to the Apechain network.", |
Add configs for Apechain testnet so it can index address lookups for D3 and display them on the explorer.
Summary by CodeRabbit