Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead #364

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead #364

merged 1 commit into from
Jul 17, 2024

Conversation

678098
Copy link
Collaborator

@678098 678098 commented Jul 17, 2024

No description provided.

@678098 678098 requested a review from a team as a code owner July 17, 2024 12:49
@678098 678098 changed the title Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead [Blocked]Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead Jul 17, 2024
@ddragan-bloomberg
Copy link
Contributor

This should be a standalone PR, not containing changes from #361

@ddragan-bloomberg
Copy link
Contributor

Remove the changes from the other PR, assign this to me, I'll merge this, then you'll rebase the other PR.

@678098
Copy link
Collaborator Author

678098 commented Jul 17, 2024

This should be a standalone PR, not containing changes from #361
Remove the changes from the other PR, assign this to me, I'll merge this, then you'll rebase the other PR.

Please wait until I finalize my PR and review after I assign it. Since you extended the scope of my work, I had to be extra careful with branches and I am perfectly okay with pushing a WIP branch with all commits.

@678098 678098 force-pushed the 240717_mwcuNoOp_bldfNoOp branch 2 times, most recently from a91e754 to 4ea2c00 Compare July 17, 2024 15:10
@678098 678098 changed the title [Blocked]Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead Jul 17, 2024
@678098
Copy link
Collaborator Author

678098 commented Jul 17, 2024

@ddragan-bloomberg the PR is ready, could you review it?

@ddragan-bloomberg
Copy link
Contributor

Looks good, should also remove mentions of mwcu_noop from https://github.com/bloomberg/blazingmq/blob/main/src/groups/mwc/mwcu/doc/mwcu.txt

@678098
Copy link
Collaborator Author

678098 commented Jul 17, 2024

Looks good, should also remove mentions of mwcu_noop from https://github.com/bloomberg/blazingmq/blob/main/src/groups/mwc/mwcu/doc/mwcu.txt

Done

chrisbeard
chrisbeard approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@chrisbeard chrisbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@678098 678098 merged commit 99e8aff into bloomberg:main Jul 17, 2024
24 checks passed
@678098 678098 deleted the 240717_mwcuNoOp_bldfNoOp branch July 17, 2024 16:50
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead (bloomber…
803ee62 
…g#364)

Signed-off-by: Evgeny Malygin <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead (bloomber…
7f30a49 
…g#364)

Signed-off-by: Evgeny Malygin <[email protected]>
alexander-e1off pushed a commit to alexander-e1off/blazingmq that referenced this pull request Oct 24, 2024
@678098 @alexander-e1off
Refactor[MWC]: remove mwcu::NoOp and use bdlf::NoOp instead (bloomber…
d181f53 
…g#364)

Signed-off-by: Evgeny Malygin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddragan-bloomberg ddragan-bloomberg ddragan-bloomberg approved these changes

@chrisbeard chrisbeard chrisbeard approved these changes

Assignees

@ddragan-bloomberg ddragan-bloomberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@678098 @ddragan-bloomberg @chrisbeard