Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api fix & cdb2-open as debug msg-trap for test #4678

Open
wants to merge 1 commit into
base: 8.0
Choose a base branch
from

Conversation

markhannum
Copy link
Contributor

Fixes bug where cdb2api incorrectly donates a comdb2db fd resolved from comdb2db.cfg (which lists host information, but not tier information) to sockpool with an incorrect typestr. The test for this cdb2_open, brought in by the 'cdb2_open_comdb2db_plugins' plugins branch. This is the 8.0 version of #4677

@markhannum
Copy link
Contributor Author

/plugin-branch cdb2_open_comdb2db_plugins_8

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

@markhannum markhannum force-pushed the cdb2_open_comdb2db_8 branch 2 times, most recently from f39b1f4 to ce25aeb Compare September 13, 2024 23:59
Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 0/0 tests failed ⚠.

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 11/556 tests failed ⚠.

The first 10 failing tests are:
sc_truncate_lockorder_generated
timepart_trunc_serialsc_generated
timepart_trunc
diskspace_nollmeta_nostripe_generated
diskspace_nollmeta
comdb2sys
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
union_parallel
lostwrite

Copy link

@roborivers roborivers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coding style check: Error. ⚠.
Smoke testing: Success ✓.
Cbuild submission: Success ✓.
Regression testing: 11/556 tests failed ⚠.

The first 10 failing tests are:
sc_newuniq_logicalsc_generated [setup failure]
timepart_trunc_serialsc_generated
timepart_trunc
diskspace_nollmeta_nostripe_generated
diskspace_nollmeta
comdb2sys_queueodh_generated
comdb2sys
comdb2sys_pagesize_generated
truncatesc
truncatesc_offline_generated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants