Improve eslint vue template #1044
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ArturoManzoli @patrickelectric I will leave this PR in draft while we don't merge the |
rafaellehmkuhl
force-pushed
the
improve-eslint-vue-template
branch
from
323ec8a
to
b934636
Compare
|
@ArturoManzoli @patrickelectric this is now ready to be reviewed. |
patrickelectric
approved these changes
Jul 9, 2024
patrickelectric
approved these changes
Jul 9, 2024
|
Will wait #1090 to be merged so we don't conflict. |
|
Me and @ArturoManzoli talked about this PR and decided to merge it only after we finish the big interface reworks. There's the edit-mode and the joystick-config still missing, so we will wait for those. |
rafaellehmkuhl
force-pushed
the
improve-eslint-vue-template
branch
from
3c855a5
to
4a299d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a lot of cases like the following:
It isn't 100% yet, and I didn't find out how to force all cases, so I've open an issue in the eslint repo to find some help.