Improve video decode performance on Electron #1567
Conversation
|
From Tony's first tests, this patch "improved performance by 99%" on Orange Pi 5. He will be making some more tests with this version on Windows and macOS, to see if there are any downsides, or we can make them default. In any case we will allow the user to set them (and warn that they need to restart the application for them to take effect). |
electron/main.ts
Outdated
| app.commandLine.appendSwitch('flag-switches-begin') | ||
| app.commandLine.appendSwitch('flag-switches-end') |
There was a problem hiding this comment.
From some documentation:
These two flags are added around the switches chrome:flags adds to the command line. This is useful to see which switches were added by chrome:flags on chrome:version. They don't have any effect.
Since there is nothing around this flags, it does not make sense to have it here.
There was a problem hiding this comment.
There was a problem hiding this comment.
Yes yes. This is a first test literally replicating the same arguments that the chromium version that Tony was running had, but those will be filtered.
rafaellehmkuhl
force-pushed
the
improve-video-decode-performance-electron
branch
from
31f868f to
b0e5936
Compare
Fix #1562