Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: deploy-cloud: Update version to support v prefix for version #1653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

patrickelectric
Copy link
Member

No description provided.

@rafaellehmkuhl
Copy link
Member

Hey Patrick. Actually @voorloopnul has told me this will not work on BlueOS Cloud, and that we need more changes in the extension and/or BlueOS Cloud itself.

Pascal, can you confirm what exactly is missing? I remember trying to change something that day and bumping into something, but I'm checking our messages now and I'm not sure anymore what exactly needs to be done.

@voorloopnul
Copy link

Hey, I might be wrong, (still on vacation brain), but I believe you and patrick pushed a change to the blueos-cloud-action to accept "v" in the docker/extension tag.

But since "v" is not part of semver specification the code on blueos-cloud will fail to work with your extension ( it will not show in bazaar ).

The easiest way to fix would be to revert the change in blueos-cloud-action, and update your CI to push cockpit with a valid semver tag.

or maybe update the blueos-cloud-action to remove a trailing "v" in the tag (which could be useful for more people that eventually include a "V" in the tag ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants