-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow data-lake variables to auto trigger actions #1675
base: master
Are you sure you want to change the base?
Allow data-lake variables to auto trigger actions #1675
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
4ef8033
to
935c0e8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The actual triggering seems to work, but:
- There's no description of the link functionality in the help text at the top
- e.g. "Actions can be run manually, or configured to trigger automatically when a linked Data Lake variable changes"
- Dropdown is light themed (and so are the others in the Actions section), while the rest of the interface uses dark ones:
- Variables aren't searchable, so you need to scroll for ages to find what you're looking for
- Configured variables can't be removed from in the bar, so they need to be found again
- Each selected pill should ideally have a little
x
on the right for removing it
- Each selected pill should ideally have a little
As something of a side note, it's hard to test using actual values, because they can't be set manually, and #1542 means sliders seemingly can't be used for integer values, and #1678 means dials aren't usable for PWM values and the like :(
Yeah... |
It works very well. For example, if water temp goes above 28º C, trigger the action that let some cold water in. |
I think it can fit here, yes. Let me give it a try! |
.
To be merged after #1674
Fix #1641