Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow data-lake variables to auto trigger actions #1675

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rafaellehmkuhl
Copy link
Member

@rafaellehmkuhl rafaellehmkuhl commented Feb 6, 2025

image

.

To be merged after #1674
Fix #1641

Copy link
Contributor

@ArturoManzoli ArturoManzoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still reviewing code, but for now, there is an UI issue:

  • Change the save button text color to white (1)

image

@rafaellehmkuhl rafaellehmkuhl force-pushed the allow-data-lake-variables-to-auto-trigger-actions branch from 4ef8033 to 935c0e8 Compare February 6, 2025 18:29
Copy link
Contributor

@ES-Alexander ES-Alexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual triggering seems to work, but:

  • There's no description of the link functionality in the help text at the top
    • e.g. "Actions can be run manually, or configured to trigger automatically when a linked Data Lake variable changes"
  • Dropdown is light themed (and so are the others in the Actions section), while the rest of the interface uses dark ones:
    Screenshot 2025-02-07 at 5 57 54 am
  • Variables aren't searchable, so you need to scroll for ages to find what you're looking for
  • Configured variables can't be removed from in the bar, so they need to be found again
    • Each selected pill should ideally have a little x on the right for removing it

As something of a side note, it's hard to test using actual values, because they can't be set manually, and #1542 means sliders seemingly can't be used for integer values, and #1678 means dials aren't usable for PWM values and the like :(

@rafaellehmkuhl
Copy link
Member Author

The actual triggering seems to work, but:
Will fix all the raised points.

As something of a side note, it's hard to test using actual values, because they can't be set manually, and #1542 means sliders seemingly can't be used for integer values, and #1678 means dials aren't usable for PWM values and the like :(

Yeah...
I need to add that functionality for adding/removing variables and persist them, but while that, try this branch, as it adds the hardcoded variables for the camera.

@ES-Alexander ES-Alexander added the docs-needed Change needs to be documented label Feb 7, 2025
@ArturoManzoli
Copy link
Contributor

It works very well.
But is it possible to set a value or a range for that data lake variable to trigger the action? If not, could it be implemented on this PR?

For example, if water temp goes above 28º C, trigger the action that let some cold water in.

@rafaellehmkuhl
Copy link
Member Author

It works very well. But is it possible to set a value or a range for that data lake variable to trigger the action? If not, could it be implemented on this PR?

For example, if water temp goes above 28º C, trigger the action that let some cold water in.

I think it can fit here, yes. Let me give it a try!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs-needed Change needs to be documented
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow actions to be triggered when associated data-lake variables change
3 participants