Add system settings manager #1685
Conversation
ArturoManzoli
force-pushed
the
1486-Cockpit-is-missing-the-option-to-reset-settings
branch
from
2194b7d to
6617c9f
Compare
src/assets/defaults.ts
Outdated
| @@ -901,3 +907,90 @@ export const defaultSensorDataloggerProfile: OverlayGrid = { | |||
| export const defaultDisplayUnitPreferences = { | |||
| distance: DistanceDisplayUnit.Meters, | |||
| } | |||
|
|
|||
| export const defaultCockpitSettings = { | |||
There was a problem hiding this comment.
I liked the idea of having all the defaults centralized in one place!
One thing thought is that we need to use those in the places where they are required (e.g.: calls to useStorage and useBlueOsStorage), otherwise if someone changes the value there, the value here will be deprecated and the code will not work.
src/assets/defaults.ts
Outdated
| { level: 'warning', enabled: true }, | ||
| { level: 'critical', enabled: true }, | ||
| ], | ||
| 'cockpit-mission-start-time': '2025-02-10T21:34:50.113Z', |
There was a problem hiding this comment.
It's crucial that we don't change the default values from what they are today. This one should be new Date(), and not that random date.
The same happens for several others. I believe you copied your own settings instead of the real defaults.
|
|
||
| // Trying to sync automatically | ||
| watch( | ||
| () => userSettings.value, |
There was a problem hiding this comment.
A tip here: it looks like you're creating an extra localStorage entry to store a duplication of all variables just to be alerted by the useStorage composable about changes in the value. You can instead just listen to the "storage" event. This way you don't duplicate everything (which can cause a lot of confusion for someone reading the stored values, as there would be two possible two sources of truth) and you can monitor for changes directly in the values of the keys.
addEventListener("storage", (event) => {});Actually, from this code, I assume you're not receiving changes made to the original settings, right?
There was a problem hiding this comment.
Correct, I'm not receiving the changes.
Actually what I was trying to do there was to check for changes on the local copy of the settings. and if there was any change, save it to the storage.
I'll implement the event listener and check the results
ArturoManzoli
force-pushed
the
1486-Cockpit-is-missing-the-option-to-reset-settings
branch
from
6617c9f to
8119e18
Compare
| @@ -519,7 +533,6 @@ const tryToPrettifyRtcConfig = (): void => { | |||
|
|
|||
| const openTutorial = (): void => { | |||
| interfaceStore.isMainMenuVisible = false | |||
| interfaceStore.configComponent = -1 | |||
There was a problem hiding this comment.
To better understand, why was this removed?
There was a problem hiding this comment.
Maybe this should be on its own commit.
On a recent PR you added a 'tools' submenu that modified a little bit the way submenus and its contents work. This was leftover from that, I suppose.
There was a problem hiding this comment.
Got it! Was a leftover indeed!
Yes, makes sense to be on a separate PR.
Sad that our linter is partially broken and not catching all errors. I should revisit the PR that fixes it at some point.
There was a problem hiding this comment.
Sorry, I meant commit and not PR 😅
ArturoManzoli
force-pushed
the
1486-Cockpit-is-missing-the-option-to-reset-settings
branch
from
8119e18 to
cb7c4d5
Compare
| Show tutorial | ||
| </v-btn> | ||
| <v-btn | ||
| v-if="isElectron()" |
There was a problem hiding this comment.
This if should not be removed. It guarantees we don't show the button to open the folder while in a browser, which doesn't work.
There was a problem hiding this comment.
That was a mistake I made. Nice that you saw. I was checking the menu with all buttons and forgot to put this back.
Returning now. Thanks
| text: 'Reset settings', | ||
| action: () => { | ||
| localStorage.clear() | ||
| location.reload() |
There was a problem hiding this comment.
This will reload the page immediately, so the snackbar won't show or will do for a quick moment.
There's a utils method that deals with warning about the reload and setting a timeout so the user can read any message left. It can help here.
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
1486-Cockpit-is-missing-the-option-to-reset-settings
branch
from
a8efdd6 to
9385ddd
Compare
Screenshare.-.2025-02-14.9_18_13.AM.mp4
Closes #1486