Add option to clone custom widgets and its contents to another view #1689
Conversation
src/stores/widgetManager.ts
Outdated
| const copyWidgetToView = (widget: Widget, viewName: string): boolean => { | ||
| let cloned = false | ||
| currentProfile.value.views.some((view) => { | ||
| if (view.name === viewName) { | ||
| const newWidget = JSON.parse(JSON.stringify(widget)) | ||
| newWidget.hash = uuid4() | ||
| view.widgets.unshift(newWidget) | ||
| cloned = true | ||
| return true | ||
| } | ||
| return false | ||
| }) | ||
| return cloned | ||
| } | ||
|
|
There was a problem hiding this comment.
Instead of returning true or false, as this is an "action" function, it should just "return void", this is, return nothing if everything goes right and throw an error in case something goes wrong.
Returning true or false in "action" functions is an old practice from languages like C that didn't have mecahisms to raise/throw errors.
|
Could we have them linked by their name (per #1527), instead of cloning by default? I think that would generally be more intuitive than needing to use a special menu on a widget, in a View you're not trying to change, to add something to a different View. Having an intuitive linking key would also allow keeping changes between them in sync automatically (which is likely usually desirable). The interface for that could be similar to GitHub's branch filtering/naming dropdown, where an empty, unnamed Custom Widget Base would have a search bar for the name, with a label like "Find or create a Custom Widget..."1, then when you type a name it filters by existing ones, and if nothing matches exactly then there's a button to "Create a new Custom Widget called XX". If we want to also support cloning then that could instead be performed when you rename one that already has mini-widgets in it. Footnotes
|
ArturoManzoli
force-pushed
the
Add-custom-widget-clone-to-view
branch
from
07c2ae9 to
ed7902b
Compare
This is a very good feature to implement. I believe that having linked elements is indeed very handy, especially when custom-made components become more complex with detailed actions and configurations. Since the input components are just getting started and users are beginning to adopt them, similar cloning results can be achieved using the feature implemented in this PR. Although re-cloning the component each time it is updated with complex configurations is needed, it's still easier than downloading the Widget's JSON, switching views, adding a Custom Widget Base, and then importing the JSON. Would you mind creating an issue to implement the linking feature you described? Regarding the “Custom Widget” name, I totally agree with you. Changing it to “collapsible container” would better describe its functionalities and the intention behind its creation. I will update the name in this PR. |
| [WidgetType.CustomWidgetBase]: true, | ||
| [WidgetType.CollapsibleContainer]: true, |
There was a problem hiding this comment.
This will cause the CustomWidgetBase widgets that people already have in their profiles to disappear.
We should perform a migration in this case.
I've added a migration.ts file in the repository some weeks ago where this can be fitted.
| showSnackbar({ | ||
| variant: 'error', | ||
| message: error.message || 'Error cloning widget.', | ||
| duration: 3000, |
There was a problem hiding this comment.
Since the default duration is 3000ms, this can be omitted and the method call will fit in a single line.
ArturoManzoli
force-pushed
the
Add-custom-widget-clone-to-view
branch
from
256868f to
a72f6e7
Compare
…ts to another view Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
Add-custom-widget-clone-to-view
branch
from
a72f6e7 to
e444941
Compare
Signed-off-by: Arturo Manzoli <[email protected]>
ArturoManzoli
force-pushed
the
Add-custom-widget-clone-to-view
branch
from
e444941 to
e78f000
Compare
|
@rafaellehmkuhl Had some issues with the migration logic, but seems ok now. |
Screenshare.-.2025-02-12.5_32_51.PM.mp4