allow admin to add PDS that are ssl or not #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-crawl-ssl-policy|RELAY_CRAWL_NONSSL = any|require|none|prod /admin/pds/crawl can add either; public requestCrawl normally SSL only BGS AllowPDSProxies for nested relay setups -allow-pds-proxy|RELAY_ALLOW_PDS_PROXY = true
brianolson
force-pushed
the
bolson/mixed-wss
branch
from
7a00551 to
f0b2d6b
Compare
ericvolp12
reviewed
Jan 15, 2025
| @@ -941,7 +944,9 @@ func (bgs *BGS) handleFedEvent(ctx context.Context, host *models.PDS, env *event | |||
| return fmt.Errorf("rebase was true in event seq:%d,host:%s", evt.Seq, host.Host) | |||
| } | |||
|
|
|||
| if host.ID != u.PDS && u.PDS != 0 { | |||
| if bgs.config.AllowPDSProxies { | |||
There was a problem hiding this comment.
Would be neat if we preconfigured the allowed hosts here via env var or something to avoid having the relay connected to itself or weird cases like that.
|
Ok with this for now to get things unblocked, but would love to un-jank all this more in the future, including all the Maybe storing hostnames separately? Also a bit worried if it becomes possible to consume from the same host both with SSL and without. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BGS and Slurper allow mixed SSL or not upstreams
-crawl-ssl-policy|RELAY_CRAWL_NONSSL = any|require|none|prod
/admin/pds/crawl can add either; public requestCrawl normally SSL only
BGS AllowPDSProxies for nested relay setups
-allow-pds-proxy|RELAY_ALLOW_PDS_PROXY = true