Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display helpful message when there’s no results #82

Merged
merged 1 commit into from
Jun 16, 2022
Merged

Display helpful message when there’s no results #82

merged 1 commit into from
Jun 16, 2022

Conversation

Jayman2000
Copy link
Contributor

Closes #80.

@antifuchs
Copy link
Collaborator

bors merge

bors bot added a commit that referenced this pull request Jun 16, 2022
@bors @Jayman2000
Merge #82
6178172 
82: Display helpful message when there’s no results r=antifuchs a=Jayman2000

Closes #80.

Co-authored-by: Jason Yundt <[email protected]>
@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Build failed:

antifuchs
antifuchs requested changes Jun 16, 2022
View reviewed changes
Copy link
Collaborator

@antifuchs antifuchs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy seems unhappy with the len() == 0 phrasing

@Jayman2000
Copy link
Contributor Author

clippy seems unhappy with the len() == 0 phrasing

Alright, I changed it to is_empty().

@antifuchs
Copy link
Collaborator

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 16, 2022

Build succeeded:

@bors bors bot merged commit bc7002d into boinkor-net:master Jun 16, 2022
@Jayman2000 Jayman2000 deleted the issue-80 branch June 16, 2022 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antifuchs antifuchs antifuchs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Suggestion: output something when there’s no results
2 participants
@Jayman2000 @antifuchs