Access filter #154
Merged
Access filter #154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm, looks like Travis CI isn't happy with PHP 5.3, but this isn't a problem with my code... |
boonebgorges
added a commit
that referenced
this pull request
Nov 14, 2017
|
Thanks, @drywall ! Before merging this, I wanted to take a few minutes to write up tests for the function, which I have now done. |
|
That's... a nicely thorough bit of tests there, wonderful. Thanks for merging, looking forward to being able to leverage this in the next release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #153, implements a filter on
invite_anyone_access_test(), which necessitated some refactoring to prevent returns from within the function.