Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(js-ts): Convert routing components to TypeScript #3979

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

devin-ai-integration[bot]
Copy link
Contributor

chore(js-ts): Convert routing components to TypeScript

Description

This PR migrates the components in src/elements/common/routing from JavaScript to TypeScript, following the provided playbook.

Changes

  • Renamed files:
    • withRouterAndRef.jswithRouterAndRef.tsx
    • index.jsindex.ts
  • Updated TypeScript types:
    • Added proper TypeScript generic types
    • Used RouteComponentProps from react-router-dom
    • Improved type safety with generics for props and ref
  • Did not modify the __tests__ directory as instructed

Verification

  • ✅ TypeScript checks pass (yarn tsc)
  • ✅ Linting passes (yarn lint)
  • ✅ Tests pass (yarn test src/elements/common/routing)

Link to Devin run

https://app.devin.ai/sessions/579609b532e24c29bf98bd257e43d6ba

Requested by

Joseph

@devin-ai-integration devin-ai-integration bot requested review from a team as code owners February 27, 2025 03:16
Copy link
Contributor Author

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR. Add "(aside)" to your comment to have me ignore it.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment and CI monitoring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants