feat(content-explorer): migrate subHeader to typescript #3999
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tjiang-box
commented
Feb 28, 2025
| import messages from '../messages'; | ||
|
|
||
| export interface AddProps { | ||
| isDisabled: boolean; |
There was a problem hiding this comment.
Added missing prop 'isDisabled'. related to this comment
tjiang-box
commented
Feb 28, 2025
| <DropdownMenu.Root> | ||
| <DropdownMenu.Trigger> | ||
| <IconButton | ||
| aria-label={formatMessage(messages.add)} |
There was a problem hiding this comment.
update aria-label to use formatMessage() to resolve this comment
tjiang-box
commented
Feb 28, 2025
| import messages from '../messages'; | ||
|
|
||
| export interface SortProps { | ||
| onSortChange: (sortBy: SortBy, sortDirection: SortDirection) => void; |
There was a problem hiding this comment.
removed sortBy and sortDirection props which were used for isSelected variable. BP's dropdown menu doesn't have isSelected prop and even with buie's dropdown menu, isSelected doesn't show any special UI change
tjiang-box
force-pushed
the
migrate_subHeader
branch
from
aa52298 to
afc5eda
Compare
greg-in-a-box
requested changes
Feb 28, 2025
| import { VIEW_FOLDER, VIEW_MODE_GRID } from '../../../../constants'; | ||
|
|
||
| describe('elements/common/sub-header/SubHeaderRight', () => { | ||
| describe('elements/common/sub-header/SubHeaderRight', () => { |
There was a problem hiding this comment.
am I reading this correctly, this is a duplicate right?
There was a problem hiding this comment.
oh good catch! let me fix this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.