Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Commit

Permalink
Fix up homebrew monkeypatching
Browse files Browse the repository at this point in the history
  • Loading branch information
@wfarr
wfarr committed Jan 28, 2013
1 parent a277ef1 commit b34506a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion files/boxen-monkeypatches.rb
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def boxen_snapshot_url
"http://s3.amazonaws.com/#{bucket}/homebrew/#{os}/#{file}"
end

def install_bottle
def install_bottle? formula
url = URI.parse boxen_snapshot_url

Net::HTTP.start url.host do |http|
Expand All @@ -33,6 +33,7 @@ def install_bottle
end

def pour
puts "Installing #{f.name} from S3..."
Dir.chdir HOMEBREW_CELLAR do
system "curl -s #{boxen_snapshot_url} | tar -xjf -"
end
Expand Down

5 comments on commit b34506a

@MikeMcQuaid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey dude. Nice work here. I'm the Homebrew guy who created bottles and just wanted to talk about this a bit as the bottle code changes often enough that I'm going to end up breaking your monkeypatching regularly. Can we talk a bit here (or by IM or mail) what you want to do with binaries and we'll work out a way to integrate this into Homebrew?

@jbarnette
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid Totally! We're taking a few minutes to relax after shipping, but if you open an issue and ref this commit I'll pull together some notes on everything we did and why, and I bet we can figure out something good.

@MikeMcQuaid
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jbarnette Done in #8. If you're in SF and want to chat over a beer this evening give me a shout (I fly back to Scotland tomorrow evening).

@jbarnette
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MikeMcQuaid Sweet, thanks! Sorry I'll miss you tonight, but I'll follow up on #8 soon. Safe trip back to Scotland.

@jbarnette
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yo @wfarr I got this, gonna explore it more next week.

Please sign in to comment.