-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: verify properties panel works in read-only mode #1013
base: main
Are you sure you want to change the base?
Conversation
What is left is three issues: * Custom styling (marking fields as disabled) * Disabling form element focus (may need to be solved in properties panel) * Hiding (+) buttons
@nithinssabu the results of our exploration. Try it out via
|
@nikku If I try to dynamically attach the properties panel like this, const propertiesPanel = modeler.get('propertiesPanel');
propertiesPanel.attachTo(propertiesContainer); Can you please have a look? I spent quite some time on it. |
@nithinssabu We touched upon that issue yesterday already. It can also be reproduced in this test case. We currently rely on a "modeling ammended"
The |
@nithinssabu For context, please share the web modeler issue you're currently working on. |
We already have styles for |
|
@nikku Can I get permission to push changes to this branch? |
00c2780
to
51f8f0a
Compare
For my use case, I also need to get linting to work in the read-only mode. Currently getting the following error: Error: No provider for "elementTemplates"! (Resolving: elementTemplates -> elementTemplates -> elementTemplates)
at error (index.esm.js:136:1)
at Object.get (index.esm.js:122:1)
at NavigatedViewer.get (index.esm.js:176:1)
at createModeler (BpmnPropertiesPanelRenderer.readonly.spec.js:142:35)
at async Context.eval (BpmnPropertiesPanelRenderer.readonly.spec.js:177:20) I pushed a commit reproducing this in the current test case. Can you please help me workaround this problem? |
51f8f0a
to
d85eeb0
Compare
I managed to get it to work by providing the |
I was able to solve these using CSS and for the keyboard focus, using Javascript to set the Screen.Recording.2024-01-15.at.18.50.47.mov@philippfromme I used |
Web modeler shipped without core support. Moving to |
Context: https://github.com/camunda/web-modeler/issues/7623.
What is left is three issues:
For the readonly properties panel case I could imagine to build dedicated support into the core:
This would do the following:
...and would in the process solve the issue of editing and focus on the HTML level.