Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support shields metadata cleanup per site on Android. #27200

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

goodov
Copy link
Member

@goodov goodov commented Jan 13, 2025

Resolves brave/brave-browser#43023

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@goodov goodov added CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x64 Do not run CI builds for Windows x64 CI/skip-macos-arm64 Do not run CI builds for macOS arm64 labels Jan 13, 2025
@goodov goodov self-assigned this Jan 13, 2025
@goodov goodov marked this pull request as ready for review January 14, 2025 04:42
@goodov goodov requested a review from a team as a code owner January 14, 2025 04:42
@goodov goodov requested a review from samartnik January 14, 2025 04:42
Copy link
Contributor

@samartnik samartnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@iefremov
Copy link
Contributor

no tests?

@goodov
Copy link
Member Author

goodov commented Jan 15, 2025

no tests?

I couldn't find a reasonable way of testing this. Looking at similar upstream changes [1] [2], it doesn't seem there's an existing place where such tests even exist.

  1. https://chromium-review.googlesource.com/c/chromium/src/+/1337623
  2. https://codereview.chromium.org/863503002

@goodov goodov merged commit 3c9c551 into master Jan 15, 2025
21 checks passed
@goodov goodov deleted the issues/43023 branch January 15, 2025 05:22
@github-actions github-actions bot added this to the 1.76.x - Nightly milestone Jan 15, 2025
@brave-builds
Copy link
Collaborator

Released in v1.76.16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-arm64 Do not run CI builds for macOS arm64 CI/skip-windows-x64 Do not run CI builds for Windows x64
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Follow up to #28904] Clearing browsing data for a specific site doesn't work
4 participants