Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restores upstream's extensions submenu in app menu. (#27574) (1.75.x). #27583

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

mkarolin
Copy link
Collaborator

@mkarolin mkarolin commented Feb 7, 2025

Resolves brave/brave-browser#43807
Uplift from #27574

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@mkarolin mkarolin self-assigned this Feb 7, 2025
@mkarolin mkarolin requested a review from a team as a code owner February 7, 2025 22:58
@kjozwiak kjozwiak added this to the 1.75.x - Release #2 milestone Feb 10, 2025
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.75.x approved 👍 QA has verified the PR on Nightly using 1.77.x as per #27574 (comment).

@kjozwiak kjozwiak merged commit d4814d1 into 1.75.x Feb 10, 2025
17 checks passed
@kjozwiak kjozwiak deleted the maxk-restore-extensions-submenu-1.75.x branch February 10, 2025 04:47
@brave-builds
Copy link
Collaborator

Released in v1.75.176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants