Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up GitHub Actions workflow #153

Merged
merged 11 commits into from
Mar 27, 2024
Merged

Clean up GitHub Actions workflow #153

merged 11 commits into from
Mar 27, 2024

Conversation

bendrucker
Copy link
Collaborator

Fixes some issues from #152

  • Duplicate trigger when opening PRs from this repo (no fork)
  • Remove Yarn, npm is just fine
  • Lint on latest LTS only
  • Test always, even if lint fails
  • Don't check types on multiple Node versions
  • Remove useless actions/checkout option (workflow only has read permissions so persist-credentials: false is unimportant)

@bendrucker bendrucker changed the title fix name Clean up GitHub Actions workflow Mar 27, 2024
@bendrucker bendrucker marked this pull request as ready for review March 27, 2024 22:44
@bendrucker bendrucker merged commit ed73d70 into master Mar 27, 2024
7 checks passed
@bendrucker bendrucker deleted the actions-workflow-cleanup branch March 27, 2024 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@bendrucker