Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(terraform): Revert feat(terraform): Add a terraform block check (#6904) #6936

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

OfekShimko
Copy link
Contributor

@OfekShimko OfekShimko commented Jan 6, 2025

User description

This reverts commit 0440c5a.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

New/Edited policies (Delete if not relevant)

Description

Include a description of what makes it a violation and any relevant external links.

Fix

How does someone fix the issue in code and/or in runtime?

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my feature, policy, or fix is effective and works
  • New and existing tests pass locally with my changes

Generated description

Below is a concise technical summary of the changes proposed in this PR:

Removes the terraform block check functionality from the Checkov tool. Deletes the StateLock check and its associated files, including test files. Modifies the base runner and other related files to remove references to the terraform registry and block checks. This change simplifies the codebase by removing a specific check for Terraform state file locking.

TopicDetails
Remove TF block check Removes the Terraform block check functionality and associated files
Modified files (9)
  • checkov/terraform/checks/terraform/base_registry.py
  • checkov/terraform/checks/terraform/__init__.py
  • checkov/terraform/checks/terraform/terraform/__init__.py
  • checkov/terraform/checks/terraform/registry.py
  • checkov/terraform/context_parsers/parsers/terraform_context_parser.py
  • checkov/terraform/base_runner.py
  • checkov/terraform/checks/terraform/base_check.py
  • checkov/terraform/runner.py
  • checkov/terraform/checks/terraform/terraform/StateLock.py
Latest Contributors(2)
UserCommitDate
SteveVakninfix-terraform-fix-fail...July 17, 2024
lirshindalmanplatform-general-remov...January 28, 2024
Remove TF block tests Removes test files related to the Terraform block check
Modified files (6)
  • tests/terraform/checks/terraform/terraform/test_StateLock.py
  • tests/terraform/checks/terraform/terraform/resources/lock/unknown.tf
  • tests/terraform/checks/terraform/terraform/__init__.py
  • tests/terraform/checks/terraform/terraform/resources/lock/pass.tf
  • tests/terraform/checks/terraform/terraform/resources/lock/fail1.tf
  • tests/terraform/checks/terraform/terraform/resources/lock/pass_dynamodb_table.tf
Latest Contributors(0)
UserCommitDate
This pull request is reviewed by Baz. Join @OfekShimko and the rest of your team on (Baz).

@OfekShimko OfekShimko changed the title Revert "feat(terraform): Add a terraform block check (#6904)" fix Revert "feat(terraform): Add a terraform block check (#6904)" Jan 6, 2025
@OfekShimko OfekShimko changed the title fix Revert "feat(terraform): Add a terraform block check (#6904)" fix(terraform) Revert "feat(terraform): Add a terraform block check (#6904)" Jan 6, 2025
@OfekShimko OfekShimko changed the title fix(terraform) Revert "feat(terraform): Add a terraform block check (#6904)" fix(terraform): Revert "feat(terraform): Add a terraform block check (#6904)" Jan 6, 2025
@OfekShimko OfekShimko changed the title fix(terraform): Revert "feat(terraform): Add a terraform block check (#6904)" fix(terraform): Revert feat(terraform): Add a terraform block check (#6904) Jan 6, 2025
@OfekShimko OfekShimko changed the title fix(terraform): Revert feat(terraform): Add a terraform block check (#6904) fix(terraform): Fix CKV_AZURE_227 for Azure V4 Jan 6, 2025
@OfekShimko OfekShimko changed the title fix(terraform): Fix CKV_AZURE_227 for Azure V4 fix(terraform): Revert feat(terraform): Add a terraform block check (#6904) Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant