Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cramtobam WDL Update #62

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

Patrick-Schlaeger-Broad

Added an updated CramToBam folder, including a CramToBam WDL along with a README.md with instructions and example for use. The CramToBam WDL was updated from an old WDL made in 2017, which is now bugged. This is fixed in the updated version.

@Patrick-Schlaeger-Broad Patrick-Schlaeger-Broad changed the title Cramtobam Update Cramtobam WDL Update Jul 25, 2024
Copy link
Collaborator

@yueyaog yueyaog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great code improvement. Minor changes are needed.

@yueyaog
Copy link
Collaborator

yueyaog commented Aug 5, 2024

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Added CramToBam to Dockstore
@Patrick-Schlaeger-Broad
Copy link
Author

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Completed! The only issue is that I don't have a test.json file for the testParameterFiles input. I just deleted that section for now, but I don't know if I will need to add one or not for it to show up correctly on Dockstore. @yueyaog

@yueyaog
Copy link
Collaborator

yueyaog commented Aug 5, 2024

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Completed! The only issue is that I don't have a test.json file for the testParameterFiles input. I just deleted that section for now, but I don't know if I will need to add one or not for it to show up correctly on Dockstore. @yueyaog

You could generate it using womtools. Can you add one using womtools input?

@Patrick-Schlaeger-Broad
Copy link
Author

Could you add this to dockstore by adding an entry in dockstore.yml file? @Patrick-Schlaeger-Broad

Completed! The only issue is that I don't have a test.json file for the testParameterFiles input. I just deleted that section for now, but I don't know if I will need to add one or not for it to show up correctly on Dockstore. @yueyaog

You could generate it using womtools. Can you add one using womtools input?

I added in a womtools input.json file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants