Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JN-1608][member's choice] editable sidebars #1452

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

connorlbark
Copy link
Collaborator

@connorlbark connorlbark commented Feb 3, 2025

DESCRIPTION (include screenshots, and mobile screenshots for participant UX)

Adds ability to customize what you see on your sidebar. Could be cool to also be able to drag n drop reorder but that's definitely a lot harder (but possible!)

Right now, this is just stored in local storage. However, I could imagine a world where this is sent to the backend as part of the user's settings just as a json blob that gets refreshed upon logging in.

Screenshot 2025-02-03 at 2 36 01 PM Screenshot 2025-02-03 at 2 36 04 PM

TO TEST: (simple manual steps for confirming core behavior -- used for pre-release checks)

  • populate at least 2 studies
  • edit sidebar (i.e. hide some stuff) in one study
  • go to another study, observe stuff isn't hidden then
  • hide some other stuff in the other study
  • switch between them and observe that state is study-specific
  • refresh, exit chrome, etc., ensure it remembers state

Copy link

sonarqubecloud bot commented Feb 3, 2025

@connorlbark connorlbark changed the title [member's choice] editable sidebars [JN-1608][member's choice] editable sidebars Feb 4, 2025
@connorlbark connorlbark marked this pull request as ready for review February 4, 2025 15:40
Copy link
Collaborator

@devonbush devonbush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is super cool. And I think we might be able to use this functionality it in other portions of our app too. But given that Juniper is going to be on a bit of a feature freeze soon, I'm leaning against merging this since it could lead to some user confusion where their screen doesn't match the documentation, or Whitney is confused why things look different in one study versus another (especially considering that menu items may also be hidden for permissions reasons)

I'll be curious to get Whitney and Parker's take -- if they say they want it, I'm on board. Otherwise maybe we we icebox this PR until the next time we add a new item to the sidebar?

@connorlbark connorlbark requested a review from devonbush February 6, 2025 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants