Skip to content

Commit

Permalink
Change test values to doubles and add epsilon in CollectHsMetricsTest
Browse files Browse the repository at this point in the history
* fix for #1987
* This should fix an issue when running tests on debian systems
  • Loading branch information
lbergelson committed Feb 11, 2025
1 parent 46d23b4 commit 8c37fe3
Showing 1 changed file with 8 additions and 3 deletions.
11 changes: 8 additions & 3 deletions src/test/java/picard/analysis/directed/CollectHsMetricsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -247,9 +247,14 @@ public void testHsMetricsF80DoesNotUseCovCap() throws IOException {

IOUtil.deleteDirectoryTree(dir);
// actual coverage should not be impacted by coverage_cap
Assert.assertEquals(highCoverageMetrics.MEAN_TARGET_COVERAGE, 100000);
Assert.assertEquals(highCoverageMetrics.MEDIAN_TARGET_COVERAGE, 100000);
Assert.assertEquals(highCoverageMetrics.FOLD_80_BASE_PENALTY, 1);

// epsilons added due to an issue when running tests on debian,
// https://github.com/broadinstitute/picard/issues/1987
// not sure if they're necessary, but they're harmless
Assert.assertEquals(highCoverageMetrics.MEAN_TARGET_COVERAGE, 100000.0, 1.E-4); // epsilons added due to an isue when running tests on debian, not sure if they're absolutely necessary but they should
// be harmless
Assert.assertEquals(highCoverageMetrics.MEDIAN_TARGET_COVERAGE, 100000.0, 1.E-4);
Assert.assertEquals(highCoverageMetrics.FOLD_80_BASE_PENALTY, 1.0, 1.E-4);
}


Expand Down

0 comments on commit 8c37fe3

Please sign in to comment.