Test accuracy should be relaxed for picard.analysis.directed.CollectHsMetricsTest.testHsMetricsF80DoesNotUseCovCap

[pgrt]

Hello,

I am in the progress of upgrading the version of picard in Debian.

When packaging version 3.3.0 I met the following issue:

java.lang.AssertionError: expected [100000] but found [100000.0]
at org.testng.Assert.fail(Assert.java:94)
at org.testng.Assert.failNotEquals(Assert.java:513)
at org.testng.Assert.assertEqualsImpl(Assert.java:135)
at org.testng.Assert.assertEquals(Assert.java:116)
at org.testng.Assert.assertEquals(Assert.java:179)
at picard.analysis.directed.CollectHsMetricsTest.testHsMetricsF80DoesNotUseCovCap(CollectHsMetricsTest.java:202)

For sure, the change

--- a/src/test/java/picard/analysis/directed/CollectHsMetricsTest.java
+++ b/src/test/java/picard/analysis/directed/CollectHsMetricsTest.java
@@ -199,9 +199,9 @@

     IOUtil.deleteDirectoryTree(dir);
     // actual coverage should not be impacted by coverage_cap

•    Assert.assertEquals(highCoverageMetrics.MEAN_TARGET_COVERAGE, 100000);
  

•    Assert.assertEquals(highCoverageMetrics.MEDIAN_TARGET_COVERAGE, 100000);
  

•    Assert.assertEquals(highCoverageMetrics.FOLD_80_BASE_PENALTY, 1);
  

•    Assert.assertEquals(highCoverageMetrics.MEAN_TARGET_COVERAGE, 100000, 1.E-4);
  

•    Assert.assertEquals(highCoverageMetrics.MEDIAN_TARGET_COVERAGE, 100000, 1.E-4);
  

•    Assert.assertEquals(highCoverageMetrics.FOLD_80_BASE_PENALTY, 1, 1.E-4);
  

  }

fixes this, it is not an interesting problem but for sure we need to avoid it.

Thanks for maintaining picard,

Best wishes,
Pierre