Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CollectSamErrorMetrics understand lowercased reference (and read) bases #1995

Conversation

yfarjoun
Copy link
Contributor

@yfarjoun yfarjoun commented Feb 7, 2025

Description

Give your PR a concise yet descriptive title
Please explain the changes you made here.
Explain the motivation for making this change. What existing problem does the pull request solve?
Mention any issues fixed, addressed or otherwise related to this pull request, including issue numbers or hard links for issues in other repos.
You can delete these instructions once you have written your PR description.


Checklist (never delete this)

Never delete this, it is our record that procedure was followed. If you find that for whatever reason one of the checklist points doesn't apply to your PR, you can leave it unchecked but please add an explanation below.

Content

  • Added or modified tests to cover changes and any new functionality
  • Edited the README / documentation (if applicable)
  • All tests passing on github actions

Review

  • Final thumbs-up from reviewer
  • Rebase, squash and reword as applicable

For more detailed guidelines, see https://github.com/broadinstitute/picard/wiki/Guidelines-for-pull-requests

- modify tests to cover this case
@yfarjoun
Copy link
Contributor Author

yfarjoun commented Feb 7, 2025

@fleharty or @kachulis I suspect this would be in your interest...

Copy link
Member

@lbergelson lbergelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @yfarjoun

@lbergelson lbergelson merged commit e38a205 into broadinstitute:master Feb 11, 2025
6 checks passed
@yfarjoun
Copy link
Contributor Author

🎉

@yfarjoun yfarjoun deleted the yf_fix_collect_sam_error_reference_case branch February 11, 2025 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CollectSamErrorMetrics (ERROR accumulator) doesn't understand lowercased reference bases
2 participants