Update to protovalidate 0.10.3 #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timostamm
commented
Mar 20, 2025
| @@ -11,12 +11,12 @@ export PATH := $(BIN):$(PATH) | |||
| export GOBIN := $(abspath $(BIN)) | |||
| # Set to use a different Python interpreter. For example, `PYTHON=python make test`. | |||
| PYTHON ?= python3 | |||
| CONFORMANCE_ARGS ?= --strict --strict_message --expected_failures=tests/conformance/nonconforming.yaml --timeout 10s | |||
| CONFORMANCE_ARGS ?= --strict_message --expected_failures=tests/conformance/nonconforming.yaml --timeout 10s | |||
There was a problem hiding this comment.
The --strict flag was removed in bufbuild/protovalidate#334
Seeing many such warnings. Likely introduced by #265. Can be dealt with separately. |
rodaine
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes changes to the conformance tests and conformance runner in v0.10.2 and v0.10.3.
For now, we're skipping 176 failing test cases: