Delete the --json flag of the conformance runner #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
timostamm
added
the
Conformance
|
Going to do some git archaeology to try to remember why we added it, but I agree it's not terribly useful. |
|
Looking at the PR that introduced it, I believe the intention was to allow it to be consumable by non-human tools. We can always add it back in later if someone desires it, but we will need to figure out how to make it work well with invalid inputs. |
rodaine
approved these changes
Mar 10, 2025
timostamm
deleted the
tstamm/Delete-the---json-flag-of-the-conformance-runner
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conformance runner is very likely to error with the
--jsonflag. For example:$ protovalidate-conformance --dump --json proto: google.protobuf.Any: unable to resolve "type.googleapis.com/foo.Bar": not foundIf a user starts using the flag only with suites that can serialize to JSON, they might build something based on the JSON output only for it to fail later on. This PR proses to simply delete the flag.