Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix build by allowing older ddbc #57

Merged
merged 1 commit into from
May 11, 2018
Merged

Conversation

John-Colvin
Copy link
Contributor

@John-Colvin John-Colvin commented May 11, 2018

or alternatively find a way to manually update code.dlang.org to recognise ddbc-0.3.8, because currently it only sees 0.3.7. See also dlang/dub-registry#338

Also, is it necessary to be so strict with the version and update it? dub will get the most recent that meets the spec, so unless the old version doesn't work then there's no need to update it in the dub.sdl, you're just forcing people to upgrade who might have a reason not to.

If you do merge this PR, please make a patch release so other people can use it.

@John-Colvin John-Colvin changed the title fix build by downgrading ddbc fix build by allowing older ddbc May 11, 2018
@SingingBush
Copy link
Collaborator

SingingBush commented May 11, 2018

ddbc 0.3.7 has problems with recent compilers, that was reason for the 0.3.8 release. Since that last ddbc tag a minor breaking change was merged so the next ddbc should be 0.4.0 to prevent use of ~>0.3.8 being an issue and allow the possibility of further 0.3.* versions as well as newer 0.4.* releases. Until ddbc 0.3.8 is available in code.dlang then there's not much point doing anything with hibernated.

@SingingBush SingingBush merged commit b21d538 into buggins:master May 11, 2018
@John-Colvin John-Colvin deleted the patch-1 branch May 12, 2018 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants