Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: When working with SQL queries with string paramters, SQL escape (') characters as (''). #93

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

vnayar
Copy link
Contributor

@vnayar vnayar commented Jun 10, 2024

During both parameter substitution as well as HQL query tokenization, the SQL escaping of (') characters as ('') is not currently respected, and results in errors like Unfinished string near (').

This fix allows one to query using string parameters that contain ' characters without encountering errors.

Copy link
Collaborator

@SingingBush SingingBush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, worth changing the writeln to an assert though

hdtest/source/embeddedtest.d Outdated Show resolved Hide resolved
@SingingBush SingingBush merged commit 7f23495 into buggins:master Jun 12, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants