Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from Transparent Path #356

Open
wants to merge 131 commits into
base: master
Choose a base branch
from
Open

Conversation

glind
Copy link
Contributor

@glind glind commented Feb 19, 2024

Purpose

Short description of the problem or feature

Approach

How does this change address the problem?

Further Info

Ticket number: #000

@mentions of the person or team responsible for reviewing proposed changes.

vishalajackus and others added 25 commits August 12, 2021 19:26
Revert "Fix issue for retrieve query by uuid"
…ganization

Added default radius for organization
* squashed migration files

* construct shipment_url only when shipment_id is present

* remove shipment related from email if shipment is not available
…ation

Handle when no custody organization mapped to custodian
* Change warning timezone to user's timezone only when core user has timezone

* append ('UTC') for UTC timezone
* removed 'Captured at' from alert message

* stop sending datetime in alert message
* github action for unit test

* update triggers for unit test github action

* github action for dev docker image build and push

* github action for demo docker image build and push

* github action for production docker image build and push

* added pre-commit hooks for dev, demo and prod branch

* update name for unit_test

* Github Actions for Unit Test (#114)

* Gunicorn timeout configuration

* Fixes done for flake
Bumps the pip group group in /requirements with 6 updates:

| Package | From | To |
| --- | --- | --- |
| [django](https://github.com/django/django) | `2.2.10` | `3.2.24` |
| [django-filter](https://github.com/carltongibson/django-filter) | `2.2.0` | `2.4.0` |
| [djangorestframework](https://github.com/encode/django-rest-framework) | `3.9.4` | `3.11.2` |
| [requests](https://github.com/psf/requests) | `2.25.0` | `2.31.0` |
| [aiohttp](https://github.com/aio-libs/aiohttp) | `3.5.4` | `3.9.2` |
| [ipython](https://github.com/ipython/ipython) | `7.2.0` | `8.10.0` |


Updates `django` from 2.2.10 to 3.2.24
- [Commits](django/django@2.2.10...3.2.24)

Updates `django-filter` from 2.2.0 to 2.4.0
- [Release notes](https://github.com/carltongibson/django-filter/releases)
- [Changelog](https://github.com/carltongibson/django-filter/blob/main/CHANGES.rst)
- [Commits](carltongibson/django-filter@2.2.0...2.4.0)

Updates `djangorestframework` from 3.9.4 to 3.11.2
- [Release notes](https://github.com/encode/django-rest-framework/releases)
- [Commits](encode/django-rest-framework@3.9.4...3.11.2)

Updates `requests` from 2.25.0 to 2.31.0
- [Release notes](https://github.com/psf/requests/releases)
- [Changelog](https://github.com/psf/requests/blob/main/HISTORY.md)
- [Commits](psf/requests@v2.25.0...v2.31.0)

Updates `aiohttp` from 3.5.4 to 3.9.2
- [Release notes](https://github.com/aio-libs/aiohttp/releases)
- [Changelog](https://github.com/aio-libs/aiohttp/blob/master/CHANGES.rst)
- [Commits](aio-libs/aiohttp@v3.5.4...v3.9.2)

Updates `ipython` from 7.2.0 to 8.10.0
- [Release notes](https://github.com/ipython/ipython/releases)
- [Commits](ipython/ipython@7.2.0...8.10.0)

---
updated-dependencies:
- dependency-name: django
  dependency-type: direct:production
  dependency-group: pip-security-group
- dependency-name: django-filter
  dependency-type: direct:production
  dependency-group: pip-security-group
- dependency-name: djangorestframework
  dependency-type: direct:production
  dependency-group: pip-security-group
- dependency-name: requests
  dependency-type: direct:production
  dependency-group: pip-security-group
- dependency-name: aiohttp
  dependency-type: direct:production
  dependency-group: pip-security-group
- dependency-name: ipython
  dependency-type: direct:production
  dependency-group: pip-security-group
...

Signed-off-by: dependabot[bot] <[email protected]>
The entire file was commented out, checking in without comments.
Fix 3.9,.2 aiohttp not found error from dependabot
…nts/pip-security-group-a44f67f13b

Bump the pip group group in /requirements with 6 updates
@glind glind requested a review from patelradhika April 5, 2024 22:02
@glind
Copy link
Contributor Author

glind commented Apr 5, 2024

Have fun reviewing this...

name: Build and Push to GCR
runs-on: ubuntu-latest
env:
IMAGE_NAME: gcr.io/spry-bricolage-298920/transparent-path/demo/buildly-core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to make these paths consistent or remove these files from the upstream

Copy link
Contributor Author

@glind glind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PIP style guide changes based on opinion are driving me crazy on this

name: Build and Push to GCR
runs-on: ubuntu-latest
env:
IMAGE_NAME: gcr.io/dev-buildly/transparent-path/buildly-core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same path problem

name: Build and Push image to GCR
runs-on: ubuntu-latest
env:
IMAGE_NAME: gcr.io/spry-bricolage-298920/transparent-path/prod/buildly-core
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

path problem

@@ -81,11 +78,13 @@
SOCIAL_AUTH_URL_NAMESPACE = 'social'
SOCIAL_AUTH_POSTGRES_JSONFIELD = True

SOCIAL_AUTH_REDIRECT_IS_HTTPS = True if os.getenv('SOCIAL_AUTH_REDIRECT_IS_HTTPS') == 'True' else False
SOCIAL_AUTH_REDIRECT_IS_HTTPS = (
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so many of these line break changes I want to fire myself and make whoever did these work on all the conflicts. Let's write a single style guide for pythonic changes and only make them during refactor releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants