Skip to content

Commit

Permalink
remove redudant tests
Browse files Browse the repository at this point in the history
Signed-off-by: Darshan Kumar <[email protected]>
  • Loading branch information
itsdarshankumar committed Dec 26, 2023
1 parent c560e9f commit d63c890
Showing 1 changed file with 0 additions and 18 deletions.
18 changes: 0 additions & 18 deletions internal/build/lifecycle_execution_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1728,14 +1728,6 @@ func testLifecycleExecution(t *testing.T, when spec.G, it spec.S) {
platformAPI = api.MustParse("0.12")
providedOrderExt = dist.Order{dist.OrderEntry{Group: []dist.ModuleRef{ /* don't care */ }}}

when("for build", func() {
extensionsForBuild = true

it("configures the phase with registry access", func() {
h.AssertSliceContains(t, configProvider.ContainerConfig().Env, "CNB_REGISTRY_AUTH={}")
})
})

when("for run", func() {
extensionsForRun = true

Expand Down Expand Up @@ -1810,16 +1802,6 @@ func testLifecycleExecution(t *testing.T, when spec.G, it spec.S) {
h.AssertSliceNotContains(t, configProvider.HostConfig().Binds, "some-kaniko-cache:/kaniko")
})
})

when("platform >= 0.10", func() {
platformAPI = api.MustParse("0.10")

it("provides -build-image and /kaniko bind", func() {
h.AssertSliceContainsInOrder(t, configProvider.ContainerConfig().Cmd, "-build-image", providedBuilderImage)
h.AssertSliceContains(t, configProvider.ContainerConfig().Env, "CNB_REGISTRY_AUTH={}")
h.AssertSliceContains(t, configProvider.HostConfig().Binds, "some-kaniko-cache:/kaniko")
})
})
})

when("not present in <layers>/generated/build", func() {
Expand Down

0 comments on commit d63c890

Please sign in to comment.