Fix deletion of ephemeral builder #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`createEphemeralBuilder` mutates the provided `rawBuilderImage`, so we must save the image name before this method is called. Signed-off-by: Natalie Arellano <[email protected]>
github-actions
bot
added
the
type/enhancement
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2260 +/- ##
==========================================
+ Coverage 70.02% 70.03% +0.01%
==========================================
Files 254 254
Lines 18673 18674 +1
==========================================
+ Hits 13074 13076 +2
+ Misses 4731 4730 -1
Partials 868 868
Flags with carried forward coverage won't be shown. Click here to find out more. |
|
Confirmed manually that with this change we don't see a |
edmorley
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
@natalieparellano Thank you for looking into this - I've tested locally using the artifact attached to the GitHub Actions run and can confirm it resolves the issue (using the STR from #2255) :-)
|
Would it be possible to release a new version of Pack CLI that includes this fix? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
createEphemeralBuildermutates the providedrawBuilderImage, so we must save the image name before this method is called.Summary
Output
Before
After
Documentation
Related
Resolves #___