Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't warn about clear-env key while parsing buildpack.toml as this is actually expected. #2261

Merged

Conversation

fumblehool
Copy link
Contributor

Fixes #2253

Summary

Output

Before

24: Pulling from heroku/builder
Digest: sha256:28390a2f5e326a0e32f041e934c0d509757d2aab0c33bb9476569557e29b8c99
Status: Image is up to date for heroku/builder:24
24: Pulling from heroku/heroku
Digest: sha256:2363090f27c848b67a06a3a269dac13f042ffeed61af27432bd3bad360ed1d0e
Status: Image is up to date for heroku/heroku:24
Warning: Ignoring unexpected key(s) in descriptor for buildpack testing-buildpack: buildpack.clear-env
Warning: Builder is trusted but additional modules were added; using the untrusted (5 phases) build flow
===> ANALYZING
[analyzer] Image with name "test-image" not found
===> DETECTING
[detector] ========

After

24: Pulling from heroku/builder
Digest: sha256:28390a2f5e326a0e32f041e934c0d509757d2aab0c33bb9476569557e29b8c99
Status: Image is up to date for heroku/builder:24
24: Pulling from heroku/heroku
Digest: sha256:2363090f27c848b67a06a3a269dac13f042ffeed61af27432bd3bad360ed1d0e
Status: Image is up to date for heroku/heroku:24
Warning: Builder is trusted but additional modules were added; using the untrusted (5 phases) build flow
===> ANALYZING
[analyzer] Image with name "test-image" not found
===> DETECTING
[detector] ======== 

Documentation

  • Should this change be documented?
    • Yes, see #___
    • No

Related

Resolves #2253

@fumblehool fumblehool requested review from a team as code owners September 8, 2024 19:53
@github-actions github-actions bot added the type/enhancement Issue that requests a new feature or improvement. label Sep 8, 2024
@github-actions github-actions bot added this to the 0.36.0 milestone Sep 8, 2024
Copy link
Member

@jjbustamante jjbustamante left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We've been having issues with these warnings, can we check if the pkg/dist/buildmodule.go has all the elements from the spec?

@fumblehool
Copy link
Contributor Author

Hi @jjbustamante
I checked for other keys but only sbom-formats and metadataare not included, as per this comment:

// FIXME: we should ideally update dist.ModuleInfo to expect sbom-formats, but this breaks other tests;

I think, we can try to fix that in separate PR.

@natalieparellano natalieparellano merged commit df70f4c into buildpacks:main Sep 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Issue that requests a new feature or improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pack warns about valid clear-env key in buildpack.toml
3 participants