Fixes #899 #910
Merged
Fixes #899 #910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lu4p thank you for coming up with a test case! I pushed what I think is a slightly better fix, with a commit message. Let me know what you think. |
We only did this for Container in the type switch, but not for Struct. The added test case panics otherwise. Just like in the previous case, we still don't need to recurse into type parameters for fieldToStruct to be filled correctly. Fixes #899
|
@mvdan LGTM can't "approve" because it's my commit |
mvdan
approved these changes
Jan 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mvdan Can you write a proper commit message for this?