various updates to support wasi:[email protected]
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes various issues: - Broken generated code indentation for resources in some cases - Type annotations that refer to non-yet-declared types confuse CPython, so we disable them - However, MyPy has no trouble with them, so we enable them by default for the `bindings` subcommand - Support WIT version annotations (i.e. pass them through to the generated component) - This partially addresses #19, but doesn't support importing or exporting multiple versions of the same interface - Update the `http` example to match `wasi:[email protected]` - Update to Wasmtime 14 and the latest `wit-parser`, `wit-component`, etc. - and update the WASI preview 1 adapter to match This also bumps the version to 0.6.0. Note that I've had to remove the `matrix-math` example since `wasmtime-py` does not yet support resources. Although the example itself doesn't use them, the new WASI Preview 1 adapter pulls them in as WASI Preview 2 imports, and there's no feasible way to work around that. Ideally, we'd provide the option to allow users to supply their own adapter, in which case we could use a pre-resource version of the adapter. However, that won't work given that pre-initialization is central to how `componentize-py` works. Hopefully we can bring back this example in the future, e.g. when `wasmtime-py` adds support for resources. Signed-off-by: Joel Dice <[email protected]> bundle `poll_loop.py` to make it available during pre-init This module is useful enough that it makes sense to bundle it as part of `componentize-py`. Eventually, we may want to distribute it via PyPI as a helper library, but we'll settle for bundling for now. It shouldn't add any overhead for apps that don't `import` it. Signed-off-by: Joel Dice <[email protected]>
dicej
force-pushed
the
wasi-http-updates
branch
from
4d3cd75 to
2edd16f
Compare
Signed-off-by: Joel Dice <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various issues:
bindingssubcommandhttpexample to matchwasi:[email protected]wit-parser,wit-component, etc.This also bumps the version to 0.6.0.
Note that I've had to remove the
matrix-mathexample sincewasmtime-pydoes not yet support resources. Although the example itself doesn't use them, the new WASI Preview 1 adapter pulls them in as WASI Preview 2 imports, and there's no feasible way to work around that. Ideally, we'd provide the option to allow users to supply their own adapter, in which case we could use a pre-resource version of the adapter. However, that won't work given that pre-initialization is central to howcomponentize-pyworks. Hopefully we can bring back this example in the future, e.g. whenwasmtime-pyadds support for resources.