Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shared heap enhancements #4069

Open
wants to merge 17 commits into
base: dev/shared_heap
Choose a base branch
from

Conversation

TianlongLiang
Copy link
Collaborator

Including two enhancements:

  1. Shared heap created from preallocated memory buffer
  2. Introduce shared heap chain

Details can be found in this issue

(WASMModuleInstanceCommon *)module_inst);
shared_heap_end_off = get_last_used_shared_heap_end_offset(
(WASMModuleInstanceCommon *)module_inst);
native_addr = shared_heap_base_addr_adj + app_buf_addr;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that shared_heap_base_addr_adj could potentially be NULL, we should move this line into the if(shared_heap_base_addr_adj) block around line 1376.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It won't be NULL if is_app_addr_in_shared_heap holds true, I will move the 1376 block here

Copy link
Collaborator

@lum1n0us lum1n0us left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants