-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable rpm package autobuilds on Fedora Copr #4688
Open
lsm5
wants to merge
1
commit into
bytecodealliance:main
Choose a base branch
from
lsm5:copr-rpm
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failing |
See: #4570 (comment) for webhook info |
CI failures are because today's release of Rust 1.63 reports a new warning. #4691 is merged fixing that, so please rebase and then hopefully CI will pass. |
Thanks @lsm5! I successfully tested the build using a basic hello world test: [vagrant@fedora36 ~]$ sudo dnf -y copr enable lsm5/wasmtime
Enabling a Copr repository. Please note that this repository is not part
of the main distribution, and quality may vary.
The Fedora Project does not exercise any power over the contents of
this repository beyond the rules outlined in the Copr FAQ at
<https://docs.pagure.org/copr.copr/user_documentation.html#what-i-can-build-in-copr>,
and packages are not held to any quality or security level.
Please do not file bug reports about these packages in Fedora
Bugzilla. In case of problems, contact the owner of this repository.
Repository successfully enabled.
[vagrant@fedora36 ~]$ sudo dnf install -y wasmtime
Copr repo for wasmtime owned by lsm5 12 kB/s | 3.3 kB 00:00
Dependencies resolved.
==============================================================================================================================================================================================================================================================================================================================
Package Architecture Version Repository Size
==============================================================================================================================================================================================================================================================================================================================
Installing:
wasmtime x86_64 101:0.0-20220815174844.df43290.fc36 copr:copr.fedorainfracloud.org:lsm5:wasmtime 3.5 M
Transaction Summary
==============================================================================================================================================================================================================================================================================================================================
Install 1 Package
Total download size: 3.5 M
Installed size: 11 M
Downloading Packages:
wasmtime-0.0-20220815174844.df43290.fc36.x86_64.rpm 18 MB/s | 3.5 MB 00:00
------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
Total 18 MB/s | 3.5 MB 00:00
Running transaction check
Transaction check succeeded.
Running transaction test
Transaction test succeeded.
Running transaction
Preparing : 1/1
Installing : wasmtime-101:0.0-20220815174844.df43290.fc36.x86_64 1/1
Running scriptlet: wasmtime-101:0.0-20220815174844.df43290.fc36.x86_64 1/1
Verifying : wasmtime-101:0.0-20220815174844.df43290.fc36.x86_64 1/1
Installed:
wasmtime-101:0.0-20220815174844.df43290.fc36.x86_64
Complete!
[vagrant@fedora36 ~]$ mkdir hello-wasmtime/; cd hello-wasmtime/
[vagrant@fedora36 hello-wasmtime]$ echo 'fn main() {
println!("Hello, world!");
}' > hello.rs
[vagrant@fedora36 hello-wasmtime]$ rustc hello.rs --target wasm32-wasi
[vagrant@fedora36 hello-wasmtime]$ wasmtime hello.wasm
Hello, world!
[vagrant@fedora36 hello-wasmtime]$ |
This commit adds `.copr/Makefile` and `.copr/wasmtime.spec.in` which combined with a webhook will trigger rpm package builds on Fedora's Copr environment after every upstream PR merge. Successful copr build needs to ensure a successful: ``` make -f .copr/Makefile srpm outdir=FOO ``` The resulting rpm package epoch:name-version-release will have the format: `101:wasmtime-0.0-$(BUILD_TIMESTAMP).$(GIT_SHORTCOMMIT).$(DIST)` - Epoch is set to 101 to override any distro-supplied wasmtime packages, regardless of version. - Version is set to 0.0 to reflect unreleased version. - The $(DIST) tag will be the output of `rpm --eval %{?dist}`. So, Fedora 36 will have `.fc36`, rhel9 will have `.el9` and so on. Fixes: bytecodealliance#4570 Signed-off-by: Lokesh Mandvekar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds
.copr/Makefile
and.copr/wasmtime.spec.in
whichcombined with a webhook will trigger rpm package builds on Fedora's Copr
environment after every upstream PR merge.
Successful copr build needs to ensure a successful:
The resulting rpm package epoch:name-version-release will have the format:
101:wasmtime-0.0-$(BUILD_TIMESTAMP).$(GIT_SHORTCOMMIT).$(DIST)
regardless of version.
rpm --eval %{?dist}
. So,Fedora 36 will have
.fc36
, rhel9 will have.el9
and so on.Fixes: #4570
Signed-off-by: Lokesh Mandvekar [email protected]
Please ensure that the following steps are all taken care of before submitting
the PR.
here.
description becomes long, the matter should probably be discussed in an issue
first.
If you don't know who could review this, please indicate so. The list of
suggested reviewers on the right can help you.
Please ensure all communication adheres to the code of
conduct.
@alexcrichton @cfallin PTAL and please include any rpm testers you know of to review this.
Successful copr build with this commit is at: https://copr.fedorainfracloud.org/coprs/lsm5/wasmtime/build/4725938/
To test the current build:
@giuseppe @font @flouthoc PTAL and test if you have the time.
I will add copr integration info in a followup comment.