Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fuzzgen: Increase allowed stack space #5825

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

afonso360
Copy link
Contributor

👋 Hey,

The motivation for this PR is the encoding error that @uweigand found in #5786. He had previously run fuzzgen on s390x and that sort of error should have been found. But it wasn't because we never generate large offsets in our stack accesses.

This PR allows larger stack slots that let us explore these larger offsets and hopefully more errors like this.

I've picked 8192 somewhat arbitrarily, it's the next largest power of two after 4096 which i suspect might be the more troublesome value, although this probably depends on the ISA.

With 8192 we have a max stack usage per function of 8 * 8192 = 65536. And with #5765 we generate at most 8 functions, so worst case 8 * 8 * 8192 = 524288 which still seems fairly reasonable.

Opening this as a draft because it has already found issues on the AArch64 backend! (#5824)

@github-actions github-actions bot added the cranelift Issues related to the Cranelift code generator label Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cranelift Issues related to the Cranelift code generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant